Fixes a number of problems with attachments #1607
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using lookup attachment and attaching through the url. I chose an image from google and it doesn't appear to be able to download it once uploaded. Download button should be linked to the Source, so it will connect with the URL |
|
Some more bugs. I changed the name. Bug 1 is that the name doesn't update until refreshed. Bug 2 is that once refreshed, the type disappears. Bug 3 is that when downloaded, the downloaded file retains the old name. |
|
Tested. And no issues with attaching files through API vs GUI. Bugs still remain as before. |
|
Submitting an attachment as part of a zip file, the name is the long string again |
|
I think that I've fixed the issues you found. Please test again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1389
It add a new field "name" to the /attach endpoint (note: API docs need updating). This name will be the displayId for the attachment. This can be specified from the GUI now.
This PR also fixes a number of problems with attachments. Should test adding file attachments and URL attachments both from the GUI and API. Should also test attachments added to collections during submission of Zip files.